Skip to content

Replace hospscotch tooltip JS library for QC Plots with tippy #1172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ankurjuneja wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Replace hospscotch tooltip JS library for QC Plots with tippy #1172

ankurjuneja wants to merge 6 commits into from

Conversation

@ankurjuneja
Copy link
Contributor

@ankurjuneja ankurjuneja commented Jan 28, 2026 •
edited
Loading

Rationale

https://github.com/LabKey/internal-issues/issues/787

Related Pull Requests

Changes

  • change qc plots data point tooltip from hopscotch to tippy
  • transform qcplothoverpanel from ext js implementation to plain js implementation

@ankurjuneja ankurjuneja mentioned this pull request Jan 28, 2026
Open
@ankurjuneja ankurjuneja marked this pull request as ready for review January 31, 2026 00:10
labkey-jeckels
labkey-jeckels reviewed Jan 31, 2026
View reviewed changes
Copy link
Contributor

@labkey-jeckels labkey-jeckels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove hopscotch as a dependency from this module? It looks like qcTrendPlotReport.jsp still references it. qcSummary.jsp does too. The latter looks like it's still actively using it. There are other references to hopscotch in the codebase - could they be replaced (they may just be CSS style names, etc)

@ankurjuneja
Copy link
Contributor Author

ankurjuneja commented Jan 31, 2026

Can we remove hopscotch as a dependency from this module? It looks like qcTrendPlotReport.jsp still references it. qcSummary.jsp does too. The latter looks like it's still actively using it. There are other references to hopscotch in the codebase - could they be replaced (they may just be CSS style names, etc)

Will do, I just replaced the qc plots data points tooltip, will replace other usage too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@labkey-jeckels labkey-jeckels labkey-jeckels left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ankurjuneja @labkey-jeckels